feat: graph component #585
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
requested changes
Nov 8, 2024
There was a problem hiding this comment.
- make this a real npm package (add package.json etc), model after https://github.com/uwdata/mosaic/tree/main/packages/inputs for example
- add
@cosmograph/cosmographas a dependency to the package - either add this client to vgplot and make an example spec with this client or
- make an example in your new package that puts the graph on a website using something like this
const el = document.querySelector("#app")
const graphWidget = new GraphComponent({element: el})
domoritz
reviewed
Nov 8, 2024
Comment on lines
+13
to
+15
| this._histogramElement = histogramElement || document.createElement('div'); | ||
| this._searchElement = searchElement || document.createElement('div'); | ||
| this._timelineElement = timelineElement || document.createElement('div'); |
There was a problem hiding this comment.
let's not do this yet until we have the graph fully working
domoritz
reviewed
Nov 8, 2024
| export class CosmographClient { | ||
| constructor(targetElement, histogramElement, searchElement, timelineElement) { | ||
| // Create containers for all components | ||
| this._element = targetElement || document.createElement('div'); |
There was a problem hiding this comment.
I think we should fail when there is no element provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391
I’ve added a client.js file to adapt the graph component using Cosmograph's api.